[webkit-reviews] review granted: [Bug 137417] Add a deprecation warning for Element.webkitMatchesSelector : [Attachment 239270] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 137417: Add a deprecation warning for Element.webkitMatchesSelector
https://bugs.webkit.org/show_bug.cgi?id=137417

Attachment 239270: Patch
https://bugs.webkit.org/attachment.cgi?id=239270&action=review

------- Additional Comments from Chris Dumez <cdumez at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=239270&action=review


> Source/WebCore/ChangeLog:12
> +	   This patch add a deprecation warning for
Element.webkitMatchesSelector with the hope

Nit: "adds"

> LayoutTests/jquery/resources/src/sizzle/sizzle.js:1203
> +		matches = html.matches || html.mozMatchesSelector ||
html.webkitMatchesSelector || html.msMatchesSelector,

I don't know what's the policy about editing scripts in the jquery folder.
Aren't we supposed to keep it matching upstream?