[webkit-reviews] review granted: [Bug 137330] RenderMathMLUnderOver adds spacing to the child operator indefinitely when resizing the window : [Attachment 239254] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 3 23:30:42 PDT 2014


Darin Adler <darin at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 137330: RenderMathMLUnderOver adds spacing to the child operator
indefinitely when resizing the window
https://bugs.webkit.org/show_bug.cgi?id=137330

Attachment 239254: Patch
https://bugs.webkit.org/attachment.cgi?id=239254&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=239254&action=review


> Source/WebCore/rendering/mathml/RenderMathMLUnderOver.cpp:77
> +    Vector<RenderMathMLOperator*> renderOperators;

Would be more efficient to put an inline capacity here so we don't do memory
allocation unless we have an unusually large number of operators.

> Source/WebCore/rendering/mathml/RenderMathMLUnderOver.cpp:97
> +    for (auto& renderOperator : renderOperators) {
> +	   renderOperator->stretchTo(stretchWidth);
>      }

No braces on a 1-line for statement body in WebKit coding style.


More information about the webkit-reviews mailing list