[webkit-reviews] review requested: [Bug 137374] Support insert iterators for Vectors. [Part 1] : [Attachment 239267] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 3 22:54:39 PDT 2014


Jer Noble <jer.noble at apple.com> has asked  for review:
Bug 137374: Support insert iterators for Vectors. [Part 1]
https://bugs.webkit.org/show_bug.cgi?id=137374

Attachment 239267: Patch
https://bugs.webkit.org/attachment.cgi?id=239267&action=review

------- Additional Comments from Jer Noble <jer.noble at apple.com>
Trying the alternative approach of making Vector compatible with
back_insert_iterator and insert_iterator. This requires Vector to have an
insert(iterator, value) method, which causes compile-time errors due to an
ambiguity between insert(iterator, value) and insert(size_t, value) when
passing in a literal (e.g., 0). So Part 1 is to rename insert(size_t, value) to
insertAt(size_t, value), and Part 2 will be adding a new insert(iterator,
value) method.


More information about the webkit-reviews mailing list