[webkit-reviews] review granted: [Bug 137339] Make it possible to test page overlays : [Attachment 239236] patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org <mitz at webkit.org> has granted Tim Horton <thorton at apple.com>'s
request for review:
Bug 137339: Make it possible to test page overlays
https://bugs.webkit.org/show_bug.cgi?id=137339

Attachment 239236: patch
https://bugs.webkit.org/attachment.cgi?id=239236&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=239236&action=review


> Source/WebCore/platform/graphics/GraphicsLayerClient.h:59
> +typedef unsigned LayerTreeAsTextBehavior;

:-/

Why not just move the definition of the enum from GraphicsLayer.h to this
header?

> Source/WebCore/testing/Internals.cpp:2370
> +

Should we also throw an exception if overlayType is not "view" or "document"?