[webkit-reviews] review granted: [Bug 137181] Implement op_profile_type in the 32-bit baseline JIT : [Attachment 239232] patch

[bugzilla-daemon at webkit.org]

Michael Saboff <msaboff at apple.com> has granted Saam Barati
<saambarati1 at gmail.com>'s request for review:
Bug 137181: Implement op_profile_type in the 32-bit baseline JIT
https://bugs.webkit.org/show_bug.cgi?id=137181

Attachment 239232: patch
https://bugs.webkit.org/attachment.cgi?id=239232&action=review

------- Additional Comments from Michael Saboff <msaboff at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=239232&action=review


r=me

> Source/JavaScriptCore/jit/JITOpcodes32_64.cpp:1350
> +    Jump skipClearLog = branchPtr(NotEqual, regT1,
TrustedImmPtr(cachedTypeProfilerLog->logEndPtr()));

This could be jumpToEnd.append(branchPtr(....)) to simplify the logic.