[webkit-reviews] review granted: [Bug 137386] REGRESSION (r173265): UIWebView PDF loading is completely broken : [Attachment 239192] patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 137386: REGRESSION (r173265): UIWebView PDF loading is completely broken
https://bugs.webkit.org/show_bug.cgi?id=137386

Attachment 239192: patch
https://bugs.webkit.org/attachment.cgi?id=239192&action=review

------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=239192&action=review


r=me

>> Source/WebKit/ios/WebView/WebPDFViewPlaceholder.mm:287
>> +	// Dump the data provider as soon as possible since the CGPDFDocument
will not hold onto it.
> 
> I'm not sure this comment makes sense to me (I'm just restoring it, but maybe
we should refrain).

Yes, let's remove the comment.	It doesn't appear to add anything useful.