[webkit-reviews] review granted: [Bug 137354] TextRun::length() should return an unsigned : [Attachment 239150] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 137354: TextRun::length() should return an unsigned
https://bugs.webkit.org/show_bug.cgi?id=137354

Attachment 239150: Patch
https://bugs.webkit.org/attachment.cgi?id=239150&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=239150&action=review


> Source/WebCore/platform/graphics/GlyphBuffer.h:127
> +    static const unsigned kNoOffset = UINT_MAX;

You could drop the initial 'k'. That doesn't match our current style. 
Using std::numeric_limits<unsigned>::max() would be more stylish than UINT_MAX.