[webkit-reviews] review granted: [Bug 137366] update-work-items should never delete items : [Attachment 239154] proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 2 16:46:11 PDT 2014
Ryosuke Niwa <rniwa at webkit.org> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 137366: update-work-items should never delete items
https://bugs.webkit.org/show_bug.cgi?id=137366
Attachment 239154: proposed patch
https://bugs.webkit.org/attachment.cgi?id=239154&action=review
------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=239154&action=review
> Tools/QueueStatusServer/handlers/updateworkitems.py:-49
> def _parse_work_items_string(self, items_string):
> - try:
> - item_strings = items_string.split(" ") if items_string else []
> - return map(int, item_strings)
> - except ValueError:
> - return None
Could you add a comment in the change log as to why we're removing try-except
here?
More information about the webkit-reviews
mailing list