[webkit-reviews] review granted: [Bug 137358] [iOS] Teach WKPDFView to navigate to pageNumber links : [Attachment 239137] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Andy Estes <aestes at apple.com>'s
request for review:
Bug 137358: [iOS] Teach WKPDFView to navigate to pageNumber links
https://bugs.webkit.org/show_bug.cgi?id=137358

Attachment 239137: Patch
https://bugs.webkit.org/attachment.cgi?id=239137&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=239137&action=review


> Source/WebKit2/UIProcess/ios/WKPDFView.mm:359
> +	   urlString = String::format("#page%lu", pageNumber);

I'm not sure String::format is the best way to do this. I realize that this
isn't performance critical code, but still probably not a great example to set.