[webkit-reviews] review granted: [Bug 137356] Simplify StringTypeAdapter templates : [Attachment 239134] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 137356: Simplify StringTypeAdapter templates
https://bugs.webkit.org/show_bug.cgi?id=137356

Attachment 239134: Patch
https://bugs.webkit.org/attachment.cgi?id=239134&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=239134&action=review


> Source/WTF/wtf/text/StringConcatenate.h:35
> +#ifndef StringView_h

Wut.

> Source/WTF/wtf/text/StringView.h:177
> +#include <wtf/text/WTFString.h>

Why is this down here?

> Source/WTF/wtf/text/StringView.h:179
> +namespace WTF {

Why a second namespace WTF?