[webkit-reviews] review granted: [Bug 137322] WKDownloadCopyRequest() returns 0 until the download starts : [Attachment 239123] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Jeff Miller
<jeffm at apple.com>'s request for review:
Bug 137322: WKDownloadCopyRequest() returns 0 until the download starts
https://bugs.webkit.org/show_bug.cgi?id=137322

Attachment 239123: Patch
https://bugs.webkit.org/attachment.cgi?id=239123&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=239123&action=review


> Source/WebKit2/UIProcess/WebPageProxy.cpp:1792
> +	   const ResourceRequest& downloadRequest =
m_decidePolicyForResponseRequest ? *m_decidePolicyForResponseRequest :
ResourceRequest();
> +	   DownloadProxy* download =
m_process->context().createDownloadProxy(downloadRequest);

I'd add a FIXME about ensuring that this ResourceRequest is never empty.