[webkit-reviews] review granted: [Bug 137352] Back TextRun with a StringView : [Attachment 239124] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 2 12:25:49 PDT 2014


Antti Koivisto <koivisto at iki.fi> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 137352: Back TextRun with a StringView
https://bugs.webkit.org/show_bug.cgi?id=137352

Attachment 239124: Patch
https://bugs.webkit.org/attachment.cgi?id=239124&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=239124&action=review


> Source/WebCore/platform/graphics/TextRun.h:219
> +    StringView m_data;

m_data is not very descriptive. Just m_string perhaps?


More information about the webkit-reviews mailing list