[webkit-reviews] review canceled: [Bug 137322] WKDownloadCopyRequest() returns 0 until the download starts : [Attachment 239119] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 2 11:36:46 PDT 2014
Jeff Miller <jeffm at apple.com> has canceled Jeff Miller <jeffm at apple.com>'s
request for review:
Bug 137322: WKDownloadCopyRequest() returns 0 until the download starts
https://bugs.webkit.org/show_bug.cgi?id=137322
Attachment 239119: Patch
https://bugs.webkit.org/attachment.cgi?id=239119&action=review
------- Additional Comments from Jeff Miller <jeffm at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=239119&action=review
>> Source/WebKit2/UIProcess/WebPageProxy.cpp:1791
>> + ASSERT(m_decidePolicyForResponseRequest);
>
> I don't think this is guaranteed to not be null.
I wasn't 100% sure about this, either. I'll update the patch to pass a
reference to ResourceRequest() if it is null.
More information about the webkit-reviews
mailing list