[webkit-reviews] review granted: [Bug 130967] erroneous date calculations on march 30, 2014 (CET/CEST time zone) the day on which daylight savings time changes : [Attachment 239091] Patch

[bugzilla-daemon at webkit.org]

José Dapena Paz <jdapena at igalia.com> has granted Byungseon Shin
<sun.shin at lge.com>'s request for review:
Bug 130967: erroneous date calculations on march 30, 2014 (CET/CEST time zone)
the day on which daylight savings time changes
https://bugs.webkit.org/show_bug.cgi?id=130967

Attachment 239091: Patch
https://bugs.webkit.org/attachment.cgi?id=239091&action=review

------- Additional Comments from José Dapena Paz <jdapena at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=239091&action=review


>> LayoutTests/js/dom/script-tests/date-DST-time-cusps.js:12
>> +	testCases.push(["(new Date('Mar 09 2014
03:00:00')).getTimezoneOffset()", "420"]);
> 
> Here you should exercise Mar 09 2014 02:00:00, and 02:10:00 and getHours
should return 3 in both cases (as in the original test case).

On Firefox the outcome is 3. On Chrome it is 1. I think both are valid. So we
can proceed with this. The ES standard is not clear about how to handle this
case anyway.