[webkit-reviews] review granted: [Bug 137303] commitqueuetasks_unittest references a non-existent member variable when mock-reporting flakey tests. : [Attachment 239048] Adds a unit test to exercise the mock

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Jake Nielsen
<jake.nielsen.webkit at gmail.com>'s request for review:
Bug 137303: commitqueuetasks_unittest references a non-existent member variable
when mock-reporting flakey tests.
https://bugs.webkit.org/show_bug.cgi?id=137303

Attachment 239048: Adds a unit test to exercise the mock
https://bugs.webkit.org/attachment.cgi?id=239048&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=239048&action=review


> Tools/Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:338
> +    def test_simple_flakey_test_failure(self):

Nit: flakey => flaky

For consistency with the majority of the Python code, including the naming of
the function report_flaky_tests() and local variable flaky_tests, we should use
"flaky" instead of "flakey". We should look to fix up the few places in the
Python code where we use the word "flakey".