[webkit-reviews] review denied: [Bug 137303] commitqueuetasks_unittest references a non-existent member variable when mock-reporting flakey tests. : [Attachment 239033] Makes the appropriate name change

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has denied Jake Nielsen
<jake.nielsen.webkit at gmail.com>'s request for review:
Bug 137303: commitqueuetasks_unittest references a non-existent member variable
when mock-reporting flakey tests.
https://bugs.webkit.org/show_bug.cgi?id=137303

Attachment 239033: Makes the appropriate name change
https://bugs.webkit.org/attachment.cgi?id=239033&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=239033&action=review


> Tools/Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:80
>      def report_flaky_tests(self, patch, flaky_results, results_archive):
> -	   flaky_tests = [result.filename for result in flaky_results]
> +	   flaky_tests = [result.test_name for result in flaky_results]
>	   _log.info("report_flaky_tests: patch='%s' flaky_tests='%s'
archive='%s'" % (patch.id(), flaky_tests, results_archive.filename))

How did you come to the decision to fix this code as opposed to removing it? I
mean, you mentioned in comment #0 that this is "unexcercised [sic] code". We
should not keep unused code in the tree.