[webkit-reviews] review granted: [Bug 137066] Fix minimal build warnings : [Attachment 238598] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 1 10:43:17 PDT 2014


Daniel Bates <dbates at webkit.org> has granted Éva Balázsfalvi
<evab.u-szeged at partner.samsung.com>'s request for review:
Bug 137066: Fix minimal build warnings
https://bugs.webkit.org/show_bug.cgi?id=137066

Attachment 238598: Patch
https://bugs.webkit.org/attachment.cgi?id=238598&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=238598&action=review


The patch looks good with the exception of the change to
Source/WebKit2/Scripts/webkit/messages.py, which isn't necessary following the
patch for bug #137107, <http://trac.webkit.org/changeset/173990>.

> Source/WebKit2/Scripts/webkit/messages.py:620
> +	   if not receiver.has_attribute(LEGACY_RECEIVER_ATTRIBUTE) or
sync_delayed_messages:

This change isn't necessary following <http://trac.webkit.org/changeset/173990>
(bug #137107).


More information about the webkit-reviews mailing list