[webkit-reviews] review granted: [Bug 137290] EWS is too eager to say that a patch does not apply to trunk of repository : [Attachment 239029] better fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Oct 1 09:58:09 PDT 2014
Ryosuke Niwa <rniwa at webkit.org> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 137290: EWS is too eager to say that a patch does not apply to trunk of
repository
https://bugs.webkit.org/show_bug.cgi?id=137290
Attachment 239029: better fix
https://bugs.webkit.org/attachment.cgi?id=239029&action=review
------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=239029&action=review
> Tools/QueueStatusServer/handlers/statusbubble.py:129
> + bubble["had_resultative_status_other_than_failure_to_apply"] =
any(map(lambda status: latest_resultative_status and
latest_resultative_status.message != "Error: " + queue.name() + " unable to
apply patch.", statuses))
Again, can we split this into two lines? It's really long.
More information about the webkit-reviews
mailing list