[webkit-reviews] review granted: [Bug 137290] EWS is too eager to say that a patch does not apply to trunk of repository : [Attachment 239012] proposed fix

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 137290: EWS is too eager to say that a patch does not apply to trunk of
repository
https://bugs.webkit.org/show_bug.cgi?id=137290

Attachment 239012: proposed fix
https://bugs.webkit.org/attachment.cgi?id=239012&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=239012&action=review


> Tools/QueueStatusServer/handlers/statusbubble.py:165
> +	   bubble["had_resultative_status_other_than_failure_to_apply"] =
any(map(lambda status: status.message not in progress_statuses and
status.message != "Patch does not apply" and status.message != "Error: " +
queue.name() + " unable to apply patch.", statuses))

Can we split this into two lines?  It's awfully long.
Alternatively, I would the variable name to did_not_fail_to_apply.

> Tools/QueueStatusServer/handlers/statusbubble.py:191
> +	   had_resultative_status_other_than_failure_to_apply = any(map(lambda
bubble: bubble["had_resultative_status_other_than_failure_to_apply"] == True,
bubbles))

No need to compare with True (i.e. remove == True).