[webkit-reviews] review canceled: [Bug 137147] [GTK] Bump up and patch dependencies to allow building for aarch64 : [Attachment 238710] Proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 1 05:56:28 PDT 2014


Akos Kiss <akiss at inf.u-szeged.hu> has canceled Akos Kiss
<akiss at inf.u-szeged.hu>'s request for review:
Bug 137147: [GTK] Bump up and patch dependencies to allow building for aarch64
https://bugs.webkit.org/show_bug.cgi?id=137147

Attachment 238710: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=238710&action=review

------- Additional Comments from Akos Kiss <akiss at inf.u-szeged.hu>
In the last some days I've been struggling to be able to answer a
self-confident yes to the question. But. At least on my box, no consecutive
runs of run-webkit-tests produce the same results, not even with the unpatched
version of the code base. There are unexpected crashes reported, some number
between 20 and 50, but almost never on the same tests. The situation is very
similar with the patched version of the code. However, by manually running the
tests reported crashing in MiniBrowser, I've never experienced any crashes.

Thus, I've been scratching my head a bit and came up with a reduced version of
the original patch, which does not tackle xserver. First of all, because I
found that the patch I wanted to introduce in the jhbuild.modules for xserver
is bugous, and also because it seems to me that the dependency of xserver on
x11proto-present-dev prevents the GTK EWS to test the patch. Hopefully, the EWS
will turn out to be more stable than my box and will signal green now. 

If so, and in case of a positive review, the xserver bump-up can be done
separately afterwards.


More information about the webkit-reviews mailing list