[webkit-reviews] review granted: [Bug 137271] [TexMap] Sprinkle range-based for-loops in GraphicsLayerTextureMapper, TextureMapperLayer : [Attachment 238963] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 1 01:02:51 PDT 2014


Sergio Villar Senin <svillar at igalia.com> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 137271: [TexMap] Sprinkle range-based for-loops in
GraphicsLayerTextureMapper, TextureMapperLayer
https://bugs.webkit.org/show_bug.cgi?id=137271

Attachment 238963: Patch
https://bugs.webkit.org/attachment.cgi?id=238963&action=review

------- Additional Comments from Sergio Villar Senin <svillar at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=238963&action=review


I love range based for loops.

I guess the style issue is a false positive, time to report a bug?

> Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:644
> +	   });

Haven't seen this before in WK code. Is it an accepted C++11 feature?


More information about the webkit-reviews mailing list