[webkit-reviews] review granted: [Bug 133415] Add a few more process specific sandbox profiles : [Attachment 232333] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat May 31 23:01:19 PDT 2014
Alexey Proskuryakov <ap at webkit.org> has granted Oliver Hunt
<oliver at apple.com>'s request for review:
Bug 133415: Add a few more process specific sandbox profiles
https://bugs.webkit.org/show_bug.cgi?id=133415
Attachment 232333: Patch
https://bugs.webkit.org/attachment.cgi?id=232333&action=review
------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=232333&action=review
> Source/WebKit2/ChangeLog:23
> + * Resources/SandboxProfiles/ios/com.apple.WebKit.Databases.sb:
Added.
> + * Resources/SandboxProfiles/ios/com.apple.WebKit.NetworkProcess.sb:
Added.
> + * Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
Added.
We still need clarity on whether naming is important.
If it is important, then "com.apple.WebKit.NetworkProcess.sb" is wrong - bundle
identifier for this process is "com.apple.WebKit.Networking", not
"com.apple.WebKit.NetworkProcess". And I'm still unsure whether there are
.Development variants, could you please check?
> Source/WebKit2/NetworkProcess/ios/NetworkProcessIOS.mm:60
> + // Need to overide the default, because service has a different bundle
ID.
Still "overide".
> Source/WebKit2/WebKit2.xcodeproj/project.pbxproj:46
> + productName = WebKit2SandBoxProfiles;
Please fix capitalization here, too.
More information about the webkit-reviews
mailing list