[webkit-reviews] review denied: [Bug 133400] Buildfix on Linux, uint64_t and unsigned long conflict : [Attachment 232284] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat May 31 16:50:17 PDT 2014
Anders Carlsson <andersca at apple.com> has denied Zsolt Borbely
<zsborbely.u-szeged at partner.samsung.com>'s request for review:
Bug 133400: Buildfix on Linux, uint64_t and unsigned long conflict
https://bugs.webkit.org/show_bug.cgi?id=133400
Attachment 232284: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=232284&action=review
------- Additional Comments from Anders Carlsson <andersca at apple.com>
I think it's wrong that there are traits for unsigned long. We should only
encode/decode explicitly sized types.
I think the right fix is to remove the unsigned long specialization, see what
breaks and then add the necessary casts.
More information about the webkit-reviews
mailing list