[webkit-reviews] review granted: [Bug 133413] REGRESSION (WebKit2): space space to insert period doesn't work in web forms : [Attachment 232310] Patch that fixes EWS

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Enrica Casucci
<enrica at apple.com>'s request for review:
Bug 133413: REGRESSION (WebKit2): space space to insert period doesn't work in
web forms
https://bugs.webkit.org/show_bug.cgi?id=133413

Attachment 232310: Patch that fixes EWS
https://bugs.webkit.org/attachment.cgi?id=232310&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=232310&action=review


> Source/WebCore/editing/VisibleUnits.cpp:1819
> +// The elements in the returned vector are:
> +// 0 - the character after the given position (if it exists)
> +// 1 - the character before the given position (if it exists)
> +// 2 - the character before the position prior to the given position (if it
exists).

Let's make the return value a struct. That way you can name all the values,
which is gonna be easier to understand at the call sites.