[webkit-reviews] review granted: [Bug 133407] Cleanup temporary setting of image interpolation quality in GraphicsContext::drawImage* : [Attachment 232301] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 30 13:33:04 PDT 2014


Darin Adler <darin at apple.com> has granted Zalan Bujtas <zalan at apple.com>'s
request for review:
Bug 133407: Cleanup temporary setting of image interpolation quality in
GraphicsContext::drawImage*
https://bugs.webkit.org/show_bug.cgi?id=133407

Attachment 232301: Patch
https://bugs.webkit.org/attachment.cgi?id=232301&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=232301&action=review


OK

> Source/WebCore/platform/graphics/GraphicsContext.cpp:98
> +    GraphicsContext* m_graphicsContext;

Should use a reference instead of a pointer.

> Source/WebCore/platform/graphics/GraphicsContext.cpp:100
> +    InterpolationQuality m_newInterpolationQuality;

Could just store a m_currentInterpolationQuality != m_newInterpolationQuality
boolean instead.


More information about the webkit-reviews mailing list