[webkit-reviews] review granted: [Bug 133401] WebCore build fix for webreplay : [Attachment 232294] Proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Zsolt Borbely
<zsborbely.u-szeged at partner.samsung.com>'s request for review:
Bug 133401: WebCore build fix for webreplay
https://bugs.webkit.org/show_bug.cgi?id=133401

Attachment 232294: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=232294&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=232294&action=review


> Source/WebCore/replay/MemoizedDOMResult.cpp:60
> +    default:
> +	   RELEASE_ASSERT_NOT_REACHED();
> +	   return nullptr;

This should be put outside the switch statement instead of in a default case.
Adding a default case turns off the warning we get when we forget to handle a
case, and we’d like to leave that on.