[webkit-reviews] review denied: [Bug 122303] Add a verbose flag to binding tests : [Attachment 232292] Patch v3
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 30 05:46:44 PDT 2014
Csaba Osztrogonác <ossy at webkit.org> has denied Tibor Mészáros
<tmeszaros.u-szeged at partner.samsung.com>'s request for review:
Bug 122303: Add a verbose flag to binding tests
https://bugs.webkit.org/show_bug.cgi?id=122303
Attachment 232292: Patch v3
https://bugs.webkit.org/attachment.cgi?id=232292&action=review
------- Additional Comments from Csaba Osztrogonác <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=232292&action=review
> Tools/Scripts/run-bindings-tests:43
> +
This extra newline is unnecessary.
> Tools/Scripts/webkitpy/bindings/main.py:117
> + elif self.verbose:
> + print 'PASS: (%s) %s' % (generator, output_file)
Please remove this extra indentation.
More information about the webkit-reviews
mailing list