[webkit-reviews] review granted: [Bug 133394] fix arm64 css jit : [Attachment 232273] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 133394: fix arm64 css jit
https://bugs.webkit.org/show_bug.cgi?id=133394

Attachment 232273: Patch
https://bugs.webkit.org/attachment.cgi?id=232273&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=232273&action=review


> Source/WebCore/cssjit/SelectorCompiler.cpp:904
> +    RELEASE_ASSERT(minimumRegisterCountForAttributes <= registerCount);

Please make this an assertion instead of a release assert.
In this case, we do not risk a security problem if the assert is false.
RegisterAllocator ensure we crash if we ever overallocate.