[webkit-reviews] review granted: [Bug 133392] HTTPHeaderMap should not derive from HashMap : [Attachment 232269] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 133392: HTTPHeaderMap should not derive from HashMap
https://bugs.webkit.org/show_bug.cgi?id=133392

Attachment 232269: Patch
https://bugs.webkit.org/attachment.cgi?id=232269&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=232269&action=review


r=me

> Source/WebCore/loader/DocumentLoader.cpp:608
> -    DEPRECATED_DEFINE_STATIC_LOCAL(AtomicString, xFrameOptionHeader,
("x-frame-options", AtomicString::ConstructFromLiteral));
> -
> -    auto it = response.httpHeaderFields().find(xFrameOptionHeader);
> +    auto it = response.httpHeaderFields().find("x-frame-options");
>      if (it != response.httpHeaderFields().end()) {

Why don't we like static local AtomicString here?