[webkit-reviews] review granted: [Bug 133366] send external playback properties to fullscreen. : [Attachment 232254] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu May 29 11:39:51 PDT 2014
Simon Fraser (smfr) <simon.fraser at apple.com> has granted Jeremy Jones
<jeremyj-wk at apple.com>'s request for review:
Bug 133366: send external playback properties to fullscreen.
https://bugs.webkit.org/show_bug.cgi?id=133366
Attachment 232254: Patch
https://bugs.webkit.org/attachment.cgi?id=232254&action=review
------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=232254&action=review
> Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:683
> + AVPlayerControllerExternalPlaybackType externalPlaybackType =
AVPlayerControllerExternalPlaybackTypeNone;
> + if (type == "airplay")
> + externalPlaybackType =
AVPlayerControllerExternalPlaybackTypeAirPlay;
> + else if (type == "tvout")
> + externalPlaybackType = AVPlayerControllerExternalPlaybackTypeTVOut;
Can't we use an enum for these types?
> Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:686
> + playerController().externalPlaybackAirPlayDeviceLocalizedName =
localizedDeviceName;
> + playerController().externalPlaybackType = externalPlaybackType;
Why do you set these if enabled == false?
> Source/WebCore/platform/ios/WebVideoFullscreenModelMediaElement.h:54
> + void updateState(const WTF::AtomicString*);
Unclear what the AtomicString represents. States are usually enum values.
> Source/WebCore/platform/ios/WebVideoFullscreenModelMediaElement.mm:82
> + static NeverDestroyed<Vector<AtomicString>> events;
> +
> + if (!events.get().size()) {
> + events.get().append(eventNames().durationchangeEvent);
> + events.get().append(eventNames().pauseEvent);
> + events.get().append(eventNames().playEvent);
> + events.get().append(eventNames().ratechangeEvent);
> + events.get().append(eventNames().timeupdateEvent);
> + events.get().append(eventNames().addtrackEvent);
> + events.get().append(eventNames().removetrackEvent);
> +
events.get().append(eventNames().webkitcurrentplaybacktargetiswirelesschangedEv
ent);
> + }
You should move this into a getter that inits the static the first time.
> Source/WebCore/platform/ios/WebVideoFullscreenModelMediaElement.mm:99
> + updateState(nullptr);
Very unclear what this means.
> Source/WebCore/platform/ios/WebVideoFullscreenModelMediaElement.mm:114
> +void WebVideoFullscreenModelMediaElement::updateState(const
WTF::AtomicString* eventType)
This needs to be called updateFromEvent() or something.
More information about the webkit-reviews
mailing list