[webkit-reviews] review granted: [Bug 133370] Crash loading skydrive.com (assertion under RemoteLayerTreeDisplayRefreshMonitor) : [Attachment 232236] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 29 06:44:35 PDT 2014


Anders Carlsson <andersca at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 133370: Crash loading skydrive.com (assertion under
RemoteLayerTreeDisplayRefreshMonitor)
https://bugs.webkit.org/show_bug.cgi?id=133370

Attachment 232236: patch
https://bugs.webkit.org/attachment.cgi?id=232236&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=232236&action=review


> Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:333
> +    HashSet<RemoteLayerTreeDisplayRefreshMonitor*> monitors =
m_displayRefreshMonitors;

I think you should use a Vector and copy the hash set to it instead, that might
be faster!


More information about the webkit-reviews mailing list