[webkit-reviews] review denied: [Bug 50418] Optimize computation of visual overflow when opacity changes : [Attachment 198193] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Bruno Abinader (history
only) <bruno.abinader at basyskom.com>'s request for review:
Bug 50418: Optimize computation of visual overflow when opacity changes
https://bugs.webkit.org/show_bug.cgi?id=50418

Attachment 198193: Patch
https://bugs.webkit.org/attachment.cgi?id=198193&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=198193&action=review


> Source/WebCore/rendering/RenderObject.h:1105
> +	   ADD_BOOLEAN_BITFIELD(needsLayoutRecompositeOnly,
NeedsLayoutRecompositeOnly);

I don't think it's right to use a RenderObject bit for this. First, it doesn't
apply to all RenderObjects (only RenderElements). Second, it's state that only
persists between style changes and not for the life of the object.