[webkit-reviews] review granted: [Bug 133324] Need an API test for bug #133193 (r169315) : [Attachment 232151] Patch

[bugzilla-daemon at webkit.org]

Andy Estes <aestes at apple.com> has granted Jon Honeycutt
<jhoneycutt at apple.com>'s request for review:
Bug 133324: Need an API test for bug #133193 (r169315)
https://bugs.webkit.org/show_bug.cgi?id=133324

Attachment 232151: Patch
https://bugs.webkit.org/attachment.cgi?id=232151&action=review

------- Additional Comments from Andy Estes <aestes at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=232151&action=review


r=me, but the StopLoadingDuringDidFailProvisionalLoadTestDone message seems
superfluous.

>
Tools/TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:4
1
> +static void didReceiveMessageFromInjectedBundle(WKContextRef context,
WKStringRef messageName, WKTypeRef messageBody, const void* clientInfo)
> +{
> +    if (WKStringIsEqualToUTF8CString(messageName,
"StopLoadingDuringDidFailProvisionalLoadTestDone"))
> +	   receivedMessageFromBundle = true;
> +}

I'm not sure I understand the purpose of the
StopLoadingDuringDidFailProvisionalLoadTestDone message.

>
Tools/TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:4
8
> +    injectedBundleClient.base.version = 0;

You already memset the entire struct to 0.

>
Tools/TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:5
7
> +    ASSERT(receivedMessageFromBundle);

You should use EXPECT_TRUE() instead.

>
Tools/TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:7
0
> +    loaderClient.base.version = 0;

You already memset the entire struct to 0.