[webkit-reviews] review granted: [Bug 133292] Class name matching should use ASCII case-insensitive matching, not Unicode case folding : [Attachment 232091] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 26 12:53:11 PDT 2014


Anders Carlsson <andersca at apple.com> has granted Darin Adler
<darin at apple.com>'s request for review:
Bug 133292: Class name matching should use ASCII case-insensitive matching, not
Unicode case folding
https://bugs.webkit.org/show_bug.cgi?id=133292

Attachment 232091: Patch
https://bugs.webkit.org/attachment.cgi?id=232091&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=232091&action=review


> Source/WebCore/dom/SpaceSplitString.cpp:197
> +    if (SpaceSplitStringData* data = table.get(keyString))
> +	   return data;

Can you .add nullptr here instead and avoid the other hash lookup below?


More information about the webkit-reviews mailing list