[webkit-reviews] review granted: [Bug 133063] Fix the quirks mode selector matching of the pseudo classes :hover and :active : [Attachment 232064] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 133063: Fix the quirks mode selector matching of the pseudo classes :hover
and :active
https://bugs.webkit.org/show_bug.cgi?id=133063

Attachment 232064: Patch
https://bugs.webkit.org/attachment.cgi?id=232064&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=232064&action=review


r=me

> Source/WebCore/css/SelectorChecker.cpp:361
> +    // In quirks mode, a compound selector selector that matches the
following conditions must not match elements that would not also match the
':any-link' selector.

The second selector in "a compound selector selector" could use single quotes
around it (the original uses italics).

> LayoutTests/ChangeLog:9
> +	   The test coverage of :hover and :active was extremly poor.
> +	   Those new tests add coverage for the cases fixed by this patch.

Thanks for extensive tests!