[webkit-reviews] review requested: [Bug 132814] [Stable] [GTK] GdiObject.h missing in WebKitGTK 2.4.1 tarball : [Attachment 232033] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 25 04:22:36 PDT 2014


Alberto Garcia <berto at igalia.com> has asked  for review:
Bug 132814: [Stable] [GTK] GdiObject.h missing in WebKitGTK 2.4.1 tarball
https://bugs.webkit.org/show_bug.cgi?id=132814

Attachment 232033: Patch
https://bugs.webkit.org/attachment.cgi?id=232033&action=review

------- Additional Comments from Alberto Garcia <berto at igalia.com>
(In reply to comment #9)
> In any case, I propose to not use my rename in the GdiObject.h, just
> feel free to use the other parts of the patch.

Here's the updated patch. I made a couple of changes:

1) I renamed GdiObject.h to GDIObject.h in the patch. That's the
   correct name of the file.

2) I removed the if TARGET_WIN32 part around it, this is a header file
   so it's not really necessary.

We should also check if the master branch is affected by this, although
that would require a separate patch if it was the case.


More information about the webkit-reviews mailing list