[webkit-reviews] review granted: [Bug 132991] [CSS Grid Layout] Children of grid containers must be turned into grid items : [Attachment 231767] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat May 24 19:26:45 PDT 2014
Darin Adler <darin at apple.com> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 132991: [CSS Grid Layout] Children of grid containers must be turned into
grid items
https://bugs.webkit.org/show_bug.cgi?id=132991
Attachment 231767: Patch
https://bugs.webkit.org/attachment.cgi?id=231767&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=231767&action=review
> Source/WebCore/css/StyleResolver.cpp:1112
> +static bool isDisplayGridBox(EDisplay display)
Should also mark this inline. While compilers are often smart enough to do that
without being asked, I see no reason not to ask explicitly.
More information about the webkit-reviews
mailing list