[webkit-reviews] review granted: [Bug 133258] [WebKit2] Rework WebPreferencesStore to allow easier overriding of defaults : [Attachment 232022] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 133258: [WebKit2] Rework WebPreferencesStore to allow easier overriding of
defaults
https://bugs.webkit.org/show_bug.cgi?id=133258

Attachment 232022: Patch
https://bugs.webkit.org/attachment.cgi?id=232022&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=232022&action=review


> Source/WebKit2/Shared/WebPreferencesStore.cpp:122
> +    }

Should have a default case that returns false.

> Source/WebKit2/Shared/WebPreferencesStore.h:386
> +	       if (m_type == Type::String)
> +		   m_string.~String();

Maybe you can factor this out into a private destroy() member function...

> Source/WebKit2/Shared/WebPreferencesStore.h:412
> +	       if (m_type == Type::String)
> +		   m_string.~String();

...and call it here too.