[webkit-reviews] review granted: [Bug 133157] [GTK] Allow to run the tests on the native X display (instead of running them inside of Xvfb) : [Attachment 231957] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Carlos Alberto Lopez Perez
<clopez at igalia.com>'s request for review:
Bug 133157: [GTK] Allow to run the tests on the native X display (instead of
running them inside of Xvfb)
https://bugs.webkit.org/show_bug.cgi?id=133157

Attachment 231957: Patch
https://bugs.webkit.org/attachment.cgi?id=231957&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=231957&action=review


>>> Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:131
>>> +		 help="Don't check the system dependencies (themes, fonts,
...)"),
>> 
>> Is this really necessary?
> 
> Not strictly necessary, but is consistent with the script for running the
layout tests run-webkit-tests:
> 
> $ Tools/Scripts/run-webkit-tests --help|grep sys
>     --nocheck-sys-deps  Don't check the system dependencies (themes)
> 
> I can drop it, if you think is better.

Unless it is necessary, let's drop this.
It is trivial to add later if needed.