[webkit-reviews] review granted: [Bug 133156] make css jit work on arm64 : [Attachment 231989] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 133156: make css jit work on arm64
https://bugs.webkit.org/show_bug.cgi?id=133156

Attachment 231989: Patch
https://bugs.webkit.org/attachment.cgi?id=231989&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=231989&action=review


> Source/WebCore/cssjit/RegisterAllocator.h:125
> +	   return Vector<JSC::MacroAssembler::RegisterID,
calleeSavedRegisterCount>(m_reservedCalleeSavedRegisters);

Do you need to explicit copy constructor here?

> Source/WebCore/cssjit/StackAllocator.h:76
> +	   stackReferences.reserveCapacity(registerCount);

reserveInitialCapacity()

> Source/WebCore/cssjit/StackAllocator.h:113
> +	   ASSERT(m_offsetFromTop >= stackUnitInBytes * registerCount);

Is this right on ARM64? You could have 2 registers by stack units.

This is probably only good for x86_64.