[webkit-reviews] review granted: [Bug 133205] [iOS] WK2: Provide implementation for windowFrame : [Attachment 231988] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 133205: [iOS] WK2: Provide implementation for windowFrame
https://bugs.webkit.org/show_bug.cgi?id=133205

Attachment 231988: Patch
https://bugs.webkit.org/attachment.cgi?id=231988&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=231988&action=review


> Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:252
> +    UIWindow* window = m_uiDelegate.m_webView.window;

if (UIWindow* window = m_uiDelegate.m_webView.window)
    ...

> Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm:312
> +    return rect; // Nothing to do on iOS

Missing period.
But I think you should remove the comment.