[webkit-reviews] review granted: [Bug 133226] Disable external playback while video plays inline with mirroring. : [Attachment 231974] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jeremy Jones
<jeremyj-wk at apple.com>'s request for review:
Bug 133226: Disable external playback while video plays inline with mirroring.
https://bugs.webkit.org/show_bug.cgi?id=133226

Attachment 231974: Patch
https://bugs.webkit.org/attachment.cgi?id=231974&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=231974&action=review


>
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundati
onObjC.mm:2327
> +    UIScreenType *mainScreen = [UIScreen mainScreen];
> +    for (UIScreenType *screen in [UIScreen screens]) {
> +	   if (![screen isEqual:mainScreen] && [screen.mirroredScreen
isEqual:mainScreen]) {
> +	       isMainScreenMirrored = true;
> +	       break;
> +	   }
> +    }

Nit: you can skip this if when in fullscreen.