[webkit-reviews] review granted: [Bug 133125] Use a per app directory structure for website data : [Attachment 231892] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org <mitz at webkit.org> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 133125: Use a per app directory structure for website data
https://bugs.webkit.org/show_bug.cgi?id=133125

Attachment 231892: Patch
https://bugs.webkit.org/attachment.cgi?id=231892&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=231892&action=review


> Source/WebKit2/ChangeLog:9
> +	   Put Website data in subdirectories of ~/Library/WebKit/<bundle
ID>/WebsiteData.

website

> Source/WebKit2/UIProcess/API/Cocoa/WKProcessPool.mm:125
> +    if (![[NSFileManager defaultManager] createDirectoryAtURL:url
withIntermediateDirectories:YES attributes:nil error:nullptr])
> +	   RELEASE_ASSERT_NOT_REACHED();

It doesn’t seem appropriate to assert that directory creation didn’t fail.
Certain external conditions, such as permissions on intermediate directories,
can make the assertion false.