[webkit-reviews] review denied: [Bug 133205] [iOS] WK2: Provide implementation for windowFrame : [Attachment 231942] Patch.

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 133205: [iOS] WK2: Provide implementation for windowFrame
https://bugs.webkit.org/show_bug.cgi?id=133205

Attachment 231942: Patch.
https://bugs.webkit.org/attachment.cgi?id=231942&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=231942&action=review


Let's talk about it tomorrow.

After reading
http://www.quirksmode.org/blog/archives/2012/03/windowouterwidt.html
it looks like we have an extra bug to fix on WebKit1... :(

> Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:252
> +    return WebCore::enclosingIntRect(m_uiDelegate.m_webView.frame);

I think you want to the bounds, not the frame.

We should have an extra step here:
-Try to get the UIWindow from the WebView. If there is a window, return that
size.
-If there is not window, return the WebView bounds.

> Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm:309
> +    FloatRect userRect(rect);
> +    userRect.scale(m_webView->_page->deviceScaleFactor());
> +    return userRect;

Sorry, that's my fault. When you said we need to convert the rect to user
space, I thought you meant in the WebProcess to convert to ContentCoordinates.

This is not right. I think you can just return the incoming rect here on iOS.