[webkit-reviews] review granted: [Bug 132951] CSS JIT: Apply backtracking optimization to adjacent backtracking : [Attachment 231904] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 132951: CSS JIT: Apply backtracking optimization to adjacent backtracking
https://bugs.webkit.org/show_bug.cgi?id=132951

Attachment 231904: Patch
https://bugs.webkit.org/attachment.cgi?id=231904&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=231904&action=review


That's awwweeesssooooome.

Great work.
The bots are sick. You don't need to update the patch, I'll land it manually
tomorrow.

> LayoutTests/fast/selectors/backtracking-adjacent-optimized.html:23
> +	   <a class="ok"></a>  <!-- Mathced. -->

Typo here: Mathced.

> LayoutTests/fast/selectors/backtracking-adjacent-optimized.html:24
> +	   <a class="ng"></a>  <!-- Failed. And backtrack from here. -->

I would duplicate this a dozen of times. That we we can to find bugs in which
we would exhaust the register allocator.