[webkit-reviews] review granted: [Bug 133182] REGRESSION(r154797): Debugger crashes when stepping over an uncaught exception : [Attachment 231902] the patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 22 14:29:49 PDT 2014


Oliver Hunt <oliver at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 133182: REGRESSION(r154797): Debugger crashes when stepping over an
uncaught exception
https://bugs.webkit.org/show_bug.cgi?id=133182

Attachment 231902: the patch.
https://bugs.webkit.org/attachment.cgi?id=231902&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=231902&action=review


> Source/JavaScriptCore/interpreter/Interpreter.cpp:455
> +	   ASSERT(!callFrame->hadException());

Why will this assertion not fire?  Can't the debugger legitimately cause an
unhanded exception?


More information about the webkit-reviews mailing list