[webkit-reviews] review granted: [Bug 133102] Add option to run-jsc-stress-tests to use installed jsc : [Attachment 231905] Updated patch with agreed upon changes

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 133102: Add option to run-jsc-stress-tests to use installed jsc
https://bugs.webkit.org/show_bug.cgi?id=133102

Attachment 231905: Updated patch with agreed upon changes
https://bugs.webkit.org/attachment.cgi?id=231905&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=231905&action=review


r=me

> Tools/Scripts/run-jsc-stress-tests:110
>      puts "--jsc		  (-j)	 Path to JavaScriptCore. This option is
required."

Let's be clearer here: "Path to JavaScriptCore build product."

> Tools/Scripts/run-jsc-stress-tests:111
> +    puts "--no-copy			 Use the existing JavaScriptCore
specified by the --jsc option."

Let's be clearer here: "Do not copy the JavaScriptCore build product before
testing. --jsc specifies an already present JavaScriptCore to test."

> Tools/Scripts/run-jsc-stress-tests:125
> +jscPathArg = ""

I'd call this "jscArg", since the argument is named "jsc" and not "jscPath".

> Tools/Scripts/run-jsc-stress-tests:178
> +	   $jscPath = Pathname.new(jscPathArg).realpath
> +    else
> +	   $jscPath = Pathname.new(jscPathArg)

Why do these disagree about realpath?

> Tools/Scripts/run-jsc-stress-tests:1040
> +	   if !$remote
> +	       $testingFrameworkPath = frameworkFromJSCPath($jscPath).realpath
> +	       $jscPath = Pathname.new($jscPath).realpath
> +	   else
> +	       $testingFrameworkPath = frameworkFromJSCPath($jscPath)

Why do these disagree about realpath?