[webkit-reviews] review denied: [Bug 133054] Performance testing, diamond-square terrain generation + canvas : [Attachment 231901] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Geoffrey Garen <ggaren at apple.com>'s
request for review:
Bug 133054: Performance testing, diamond-square terrain generation + canvas
https://bugs.webkit.org/show_bug.cgi?id=133054

Attachment 231901: Patch
https://bugs.webkit.org/attachment.cgi?id=231901&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=231901&action=review


> PerformanceTests/Canvas/terrain.html:197
> +	   benchmark(function() {
> +	       var terrain = new Terrain(9);
> +	       terrain.generate(0.5);
> +	       ctx.clearRect(0, 0, width, height);
> +	       terrain.draw(ctx, width, height);
> +	   });

We should use PerfTestRunner.measureTime or reportValueAsync so that perf bots
would be able to run this test.