[webkit-reviews] review granted: [Bug 131024] [UNIX] Reorganize and cleanup main functions of GTK and EFL ports : [Attachment 228269] Try to fix EFL build

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 131024: [UNIX] Reorganize and cleanup main functions of GTK and EFL ports
https://bugs.webkit.org/show_bug.cgi?id=131024

Attachment 228269: Try to fix EFL build
https://bugs.webkit.org/attachment.cgi?id=228269&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=228269&action=review


I'm unsure how much complexity and code this saves, it doesn't look like a lot,
but I you're probably a better judge of that than me. One thing that bothers me
is that in theory we could use these same implementations for Gtk on Windows,
say, but I guess Unix is still sensible as a name since we'd be using GNU
libraries even on windows, so r=me.

> Source/WebKit2/ChangeLog:8
> +	   Move main function implementation files to
<process-dir>/EntryPoint/unix/ProcessNameMain.cpp

add <> around ProcessName to be clearer?