[webkit-reviews] review granted: [Bug 133175] Captions layout incorrectly in fullscreen. : [Attachment 231868] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jeremy Jones
<jeremyj-wk at apple.com>'s request for review:
Bug 133175: Captions layout incorrectly in fullscreen.
https://bugs.webkit.org/show_bug.cgi?id=133175

Attachment 231868: Patch
https://bugs.webkit.org/attachment.cgi?id=231868&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=231868&action=review


> Source/WebCore/html/shadow/MediaControlElements.cpp:1366
>	       setInlineStyleProperty(CSSPropertyWidth,
m_videoDisplaySize.size().width(), CSSPrimitiveValue::CSS_PX);
>	       setInlineStyleProperty(CSSPropertyHeight,
m_videoDisplaySize.size().height(), CSSPrimitiveValue::CSS_PX);
> +	       setInlineStyleProperty(CSSPropertyPosition, CSSValueAbsolute);
> +	       setInlineStyleProperty(CSSPropertyLeft, 0,
CSSPrimitiveValue::CSS_PX);
> +	       setInlineStyleProperty(CSSPropertyTop, 0,
CSSPrimitiveValue::CSS_PX);

Nit: this should be in a member function instead of being duplicated here and
in updateTimerFired.